[PATCH] D63476: [ARM] DLS/LE low-overhead loop code generation

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:76
+  BBUtils = std::unique_ptr<ARMBasicBlockUtils>(new ARMBasicBlockUtils(MF));
+  BBUtils->computeAllBlockSizes();
+
----------------
dmgreen wrote:
> samparker wrote:
> > dmgreen wrote:
> > > How expensive is this? We might as well not do it for cores that won't have low overhead loops.
> > Good point! I'll add a check and an exit.
> Also, I'm not sure it's doing everything it should, and might not be calculating offsets. Can you add a test with multiple loop bbs that together go over the limit?
sounds good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63476/new/

https://reviews.llvm.org/D63476