[PATCH] D62680: [ARM] Add MVE vector load/store instructions.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham marked 5 inline comments as done.
simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3611
+
+// Trivial multiclass (only defining one thing), with the same API as
+// the previous one, for use when the memory size is one byte, so
----------------
ostannard wrote:
> Why is this needed, could we just define instances of MVE_VLDRSTR_rq directly below?
The idea was partly to abstract away all the parameters to MVE_VLDRSTR_rq that are common between the byte variants, and mostly to make all the defms look similar enough that the reader can focus on only the //necessary// differences.

Perhaps a one-element defm was silly and I should turn it into an ordinary subclass, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62680/new/

https://reviews.llvm.org/D62680