[PATCH] D63521: Teach the symbolizer lib symbolize objects directly.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 01:51:50 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:82
+
+  // TODO: codeview is not supported yet.
+  Expected<SymbolizableModule *> InfoOrErr = createModuleInfo({&Obj, &Obj},
----------------
This TODO seems somewhat arbitrary in this location. Is CodeView supported for other parts of LLVM symbolizer? What would happen if somebody tried to use this bit of code with CodeView, compared with old behaviour?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63521/new/

https://reviews.llvm.org/D63521





More information about the llvm-commits mailing list