[PATCH] D63752: Fix an issue that common symbols are not internalized under some condition.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/ELF/lto/common4.ll:4
+;; Make sure that common symbols are properly internalized.
+;; In this file, @a is a module-local common symbol, so LTO
+;; should be able to internelize it.
----------------
I am not sure if module-local is a proper term here.

`@a` does not have to exported (ExportDynamic) because there is no DSO has an undefined symbol named `a`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63752/new/

https://reviews.llvm.org/D63752