[PATCH] D63752: Fix an issue that common symbols are not internalized under some condition.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 23:24:29 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/common4.ll:13
+ at a = common dso_local local_unnamed_addr global i32 0, align 4
+; CHECK-DAG: @a = internal global i32 0, align 4
----------------
Probably add a comment saying `@a` does not interpose a symbol in a DSO so it does not have to be exported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63752/new/

https://reviews.llvm.org/D63752





More information about the llvm-commits mailing list