[PATCH] D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3.

Mon Jun 24 22:55:56 PDT 2019

thakis added a comment.

In D63674#1556504 <https://reviews.llvm.org/D63674#1556504>, @delcypher wrote:

> @hans
>
> In D63674#1555149 <https://reviews.llvm.org/D63674#1555149>, @hans wrote:
>
> > In D63674#1554533 <https://reviews.llvm.org/D63674#1554533>, @delcypher wrote:
> >
> > > @hans @thakis Could one of you check that this patch doesn't break your build?
> >
> >
> > We don't get a CMake error anymore,
>
>
> Great!
>
> > but the build no longer produces lib/clang/9.0.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib after this patch.
>
> This patch doesn't change (AFAICT) which Apple OSs get built for. It only changes the code that generates test configurations for the different sanitizers. AFAICT it is code already in trunk (`cmake/config-ix.cmake`) that decides if compiler-rt will build for the `iossim` OS. The code requires the iOS simulator SDKs to be present in your toolchain. If you don't have the iOS simulator SDK I don't think the ASan iossim dylib will be created. I don't understand how you managed to produce the `lib/clang/9.0.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib` file previously because it should not be possible without the iOS simulator SDK.
>
> The only thing I can think of is your bot was doing an incremental build and your `lib/clang/9.0.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib` file is a stale file from an old build where creation of `lib/clang/9.0.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib` was possible.

(FWIW our bots all do clobber builds, so this can't be it.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63674/new/

https://reviews.llvm.org/D63674