[PATCH] D63696: [WebAssembly] Fix list of relocations with addends in lld
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 24 16:54:29 PDT 2019
sbc100 added a comment.
Thanks!
I guess this means we are also missing a test case for `--emit-relocs` + `-fPIC`?
================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:169
+ static bool hasAddend(unsigned Type);
+ inline bool hasAddend() const { return hasAddend(Type); };
};
----------------
Rather than adding methods to this struct can you implement in the same way that `relocTypetoString` is below?
Perhaps we can make them methods later, but I'm currently a fan of keeping the struct definitions clean so they can be easily matched with the binary spec.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63696/new/
https://reviews.llvm.org/D63696
More information about the llvm-commits
mailing list