[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

Mon Jun 24 16:40:47 PDT 2019

sstefan1 added a comment.

In D62766#1555926 <https://reviews.llvm.org/D62766#1555926>, @jfb wrote:

> Please add tests for the things I mention in comments, as well as:
>
> - relaxed volatile atomic load / store
> - inline assembly

Only added one test for now. I will add more tomorrow.

In D62766#1555578 <https://reviews.llvm.org/D62766#1555578>, @jdoerfert wrote:

> Sorry for my delayed review, I want to move this ahead now and commit it.
>
> Can you make sure this works on top-of-trunk (origin/master), hence, rebase it please. Also make sure `make check-all` works without problems.

@jdoerfert  As for the intrinsics. I added checks for memcpy, memmove & memset as @jfb suggested. What do you think? I also kept the FIXME comment which can indicate that we might take a different approach. I did `make check-all` there were few problems with some FunctionAttr tests not checking for nosync attributes. I will fix that tomorrow. Also I seem to have a problem with a `test/Bitcode/attributes.ll` with nobuiltin attribute.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766