[llvm] r364252 - [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI

Seiya Nuta via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 16:39:01 PDT 2019


Author: seiya
Date: Mon Jun 24 16:39:01 2019
New Revision: 364252

URL: http://llvm.org/viewvc/llvm-project?rev=364252&view=rev
Log:
[llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI

Summary:
Use MachOObjectFile::isRelocationScattered instead of reinterpret_cast.

Fixes https://bugs.llvm.org/show_bug.cgi?id=42360

Reviewers: alexshap, rupprecht, jhenderson

Reviewed By: alexshap

Subscribers: dendibakh, bjope, uabelho, jakehehrlich, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63699

Modified:
    llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp

Modified: llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp?rev=364252&r1=364251&r2=364252&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/MachO/MachOReader.cpp Mon Jun 24 16:39:01 2019
@@ -101,9 +101,7 @@ extractSections(const object::MachOObjec
       RelocationInfo R;
       R.Symbol = nullptr; // We'll fill this field later.
       R.Info = MachOObj.getRelocation(RI->getRawDataRefImpl());
-      R.Scattered =
-          reinterpret_cast<MachO::scattered_relocation_info *>(&R.Info)
-              ->r_scattered;
+      R.Scattered = MachOObj.isRelocationScattered(R.Info);
       S.Relocations.push_back(R);
     }
 




More information about the llvm-commits mailing list