[PATCH] D63671: [llvm-profdata] [NFC] Avoir keeping reference to every files

Mon Jun 24 16:05:35 PDT 2019

paulsemel added a comment.

In D63671#1554457 <https://reviews.llvm.org/D63671#1554457>, @wmi wrote:

> We had better have a test for it. It is not a strict NFC and we best verify it works as we expect -- like if we miss any place which still uses StringRef refering to string in file data buffer, we may have dangling pointer after we free the buffer.

I agree with you that this is not completely NFC. However, I didn't really see what could best test this functionality (anyway, in our case, accessing dangling pointer would lead to SIGSEGV as we unmap the files).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63671/new/

https://reviews.llvm.org/D63671