[PATCH] D63735: [MachOObjectFile]Added Valid Architecture Function

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:58
 
+  std::array<StringRef, 17> validArchs = {
+      "i386",   "x86_64", "x86_64h",  "armv4t",  "arm",    "armv5e",
----------------
missing const,
plus i'd move it out of the anonymous namespace and make it static (it doesn't change anything, just a convention in the LLVM codebase).
P.S. unfortunately, it looks like it can't be "constexpr" since the constructor 
StringRef(const char *Str)  is not constexpr at the moment.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:2726
 bool MachOObjectFile::isValidArch(StringRef ArchFlag) {
-  return StringSwitch<bool>(ArchFlag)
-      .Case("i386", true)
-      .Case("x86_64", true)
-      .Case("x86_64h", true)
-      .Case("armv4t", true)
-      .Case("arm", true)
-      .Case("armv5e", true)
-      .Case("armv6", true)
-      .Case("armv6m", true)
-      .Case("armv7", true)
-      .Case("armv7em", true)
-      .Case("armv7k", true)
-      .Case("armv7m", true)
-      .Case("armv7s", true)
-      .Case("arm64", true)
-      .Case("arm64_32", true)
-      .Case("ppc", true)
-      .Case("ppc64", true)
-      .Default(false);
+  return std::find(validArchs.begin(), validArchs.end(), ArchFlag) !=
+         validArchs.end();
----------------
cbegin, cend


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63735/new/

https://reviews.llvm.org/D63735