[PATCH] D63680: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map.
George Burgess IV via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 24 14:15:16 PDT 2019
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
thanks for this!
just a single optional style nit.
================
Comment at: lib/Transforms/Utils/LoopRotationUtils.cpp:379
+ // not whether it can be remapped to a simplified value.
+ ValueMapMSSA[Inst] = C;
}
----------------
are these all intended to turn into inserts, or is the intent to overwrite old values, too?
in the former case, please do the (admittedly obnoxious to type)
```
bool Inserted = ValueMapMSSA.insert({Inst, C}).second;
(void)Inserted;
assert(Inserted);
```
unless `Foo[X] = Bar;` is by far the dominant style in this file
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63680/new/
https://reviews.llvm.org/D63680
More information about the llvm-commits
mailing list