[PATCH] D63736: [GWP-ASan] Guard against recursive allocs. Pack TLS for perf.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:131
+  ScopedBoolean(bool &B) : Bool(B) { Bool = !Bool; }
+  ~ScopedBoolean() { Bool = !Bool; }
+
----------------
Set to true in constructor, false in destructor. This !Bool stuff makes the code harder to read for no reason at all.


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.h:249
+  // variables in GWP-ASan.
+  struct ThreadLocalPackedVariables {
+    constexpr ThreadLocalPackedVariables() {}
----------------
alignas(8), at least


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63736/new/

https://reviews.llvm.org/D63736