[PATCH] D63476: [ARM] DLS/LE low-overhead loop code generation

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

This looks good to me. I.e., the approach of expanding the pseudos as late as possible, and the availability of size estimation in TTI for these pseudos, seems the right approach to me. I hope that when overestimate the size, if necessary, that this will be always be safe.

So  I am happy with this, if Dave is happy with this too.



================
Comment at: test/Transforms/HardwareLoops/ARM/massive.mir:47
+  
+  ; Function Attrs: nounwind
+  declare i32 @llvm.arm.space(i32, i32) #1
----------------
a proper nit: just a minor clean up, but we don't need these comments on the functions


================
Comment at: test/Transforms/HardwareLoops/ARM/massive.mir:57
+  ; Function Attrs: nounwind
+  declare void @llvm.stackprotector(i8*, i8**) #1
+  
----------------
and this stack protector stuff


================
Comment at: test/Transforms/HardwareLoops/ARM/massive.mir:63
+  
+  !llvm.module.flags = !{!0, !1}
+  !llvm.ident = !{!2}
----------------
and these attributes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63476/new/

https://reviews.llvm.org/D63476