[PATCH] D62088: [compiler-rt][builtins] Scaled Integer log10()

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

> Is there not a function for that already in compiler-rt?  Or is the problem that it doesn't necessarily exist, e.g. if we're supporting a 64-bit scaled integer type but not a 128-bit integer type?

Yes, the extra functions are for if 64 bit scaled ints are supported but we aren't able to use 128 bit ints. There is `__udivmodti4` which does 128 bit division, but only if 128 bit ints are enabled.

> At any rate, I'd say it's better to have the operation with a big code-size cost than to not reliably have it.

Added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62088/new/

https://reviews.llvm.org/D62088