[PATCH] D63518: WIP BitStream reader: propagate errors

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 11:18:24 PDT 2019


jfb updated this revision to Diff 206269.
jfb added a comment.

- Remove on error propagation, which a test relies on. We should fix it in a separate patch.
- pch-from-libclang.c isn't cleaning its temp files before running, which makes reproducing issues that much more painful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63518/new/

https://reviews.llvm.org/D63518

Files:
  clang/include/clang/Basic/Diagnostic.h
  clang/include/clang/Frontend/FrontendAction.h
  clang/include/clang/Serialization/ASTReader.h
  clang/include/clang/Serialization/GlobalModuleIndex.h
  clang/lib/Frontend/ASTUnit.cpp
  clang/lib/Frontend/CompilerInstance.cpp
  clang/lib/Frontend/FrontendAction.cpp
  clang/lib/Frontend/PrecompiledPreamble.cpp
  clang/lib/Frontend/Rewrite/FrontendActions.cpp
  clang/lib/Frontend/SerializedDiagnosticReader.cpp
  clang/lib/Frontend/TestModuleFileExtension.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTReaderDecl.cpp
  clang/lib/Serialization/ASTReaderStmt.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp
  clang/test/Index/pch-from-libclang.c
  llvm/include/llvm/Bitcode/BitstreamReader.h
  llvm/include/llvm/Support/Error.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/BitstreamReader.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
  llvm/unittests/Bitcode/BitstreamReaderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63518.206269.patch
Type: text/x-patch
Size: 170586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190624/66743f9b/attachment-0001.bin>


More information about the llvm-commits mailing list