[PATCH] D63689: llvm-cov don't fail the entire invocation if one of the provided object doesn't contain coverage info

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for the patch.



================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:297
+                         return Error(std::move(CME));
+                       });
+      if (E) {
----------------
Could you please rebase this patch on top of r363325 (D63232)?


================
Comment at: llvm/test/tools/llvm-cov/empty_object.test:1
+RUN: clang -std=c++11 -mllvm -enable-name-compression=false -fprofile-instr-generate -fcoverage-mapping %S/Inputs/empty_object/empty_object.cc -c -o %t.o
+
----------------
Please check in the .o file instead of invoking clang, as it won't be available on the buildbots.


================
Comment at: llvm/test/tools/llvm-cov/empty_object.test:11
+It should still fail if no other valid object is provided.
+RUN: (! llvm-cov report -instr-profile %S/Inputs/empty_object/merged.profdata \
+RUN:   -object %t.o) 2>&1 | FileCheck -check-prefix=FAIL %s
----------------
IIRC the syntax for expected-to-fail RUN commands is 'not <command>'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63689/new/

https://reviews.llvm.org/D63689