[PATCH] D59225: [profile] Support for GCDA profiling in Fuchsia

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 10:45:31 PDT 2019


vsk added a comment.

This looks ok to me. In the longer term, I think compiler-rt would benefit from borrowing/extending llvm's generic file interface to abstract over platform differences. It doesn't seem ideal to me that libprofile/xray etc. have lots of platform-specific file I/O code.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59225/new/

https://reviews.llvm.org/D59225





More information about the llvm-commits mailing list