[PATCH] D62681: [ARM] Add remaining miscellaneous MVE instructions.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:7748
   }
-  case ARM::t2WLS: {
+  case ARM::t2WLS:
+  case ARM::MVE_WLSTP_8:
----------------
It would be better to do these as checks on the operands, rather than the whole instruction.


================
Comment at: llvm/test/MC/ARM/mve-misc.s:2
+# RUN: not llvm-mc -triple=thumbv8.1m.main-none-eabi -mattr=+mve -show-encoding  < %s \
+# RUN:   | FileCheck --check-prefix=CHECK-NOFP %s
+# RUN: not llvm-mc -triple=thumbv8.1m.main-none-eabi -mattr=+mve.fp,+fp64 -show-encoding  < %s 2>%t \
----------------
If nothing is expected to vary between the FP and no-FP cases, the check lines can be merged, and the errors checked for both cases.


================
Comment at: llvm/test/MC/ARM/mve-misc.s:17
+# CHECK-NOFP: wlstp.8     lr, r0, #1668  @ encoding: [0x00,0xf0,0x43,0xc3]
+wlstp.8     lr, r0, #1668
+
----------------
Are these instructions expected to work with label operands now (in which case that should be tested), or is that coming in a later patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62681/new/

https://reviews.llvm.org/D62681