[PATCH] D63528: InstCombine: Preserve nuw when reassociating nuw ops [3/3]

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 08:50:57 PDT 2019


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Looks good.



================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:595
     // Check if we can add NSW flag to SimplifiedInst. If so, set NSW flag.
     // TODO: Check for NUW.
     if (BinaryOperator *BO = dyn_cast<BinaryOperator>(SimplifiedInst)) {
----------------
lebedev.ri wrote:
> Outdated comment?
Still outdated?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63528/new/

https://reviews.llvm.org/D63528





More information about the llvm-commits mailing list