[PATCH] D63484: AMDGPU/GlobalISel: Make s16 G_ICMP legal

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 08:47:51 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/regbankselect-icmp.mir:1
-# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -march=amdgcn -mcpu=fiji -run-pass=regbankselect %s -verify-machineinstrs -o - -regbankselect-fast | FileCheck %s
----------------
nhaehnle wrote:
> Why stop autogenerating this? Why remove the CHECK lines?
This is a bad diff, all the checks should be generated


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63484/new/

https://reviews.llvm.org/D63484





More information about the llvm-commits mailing list