[PATCH] D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:269
+  if (Symtab->sh_type == ELF::SHT_SYMTAB) {
+    SymTable = (*SymtabOrErr);
+    SymbolNames.resize(SymTable.size());
----------------
superfluous `()`?


================
Comment at: tools/yaml2obj/yaml2elf.cpp:273
+    return S;
+  return S.slice(0, SuffixPos);
+}
----------------
`.substr`

This should ease transition to `std::string_view` when llvm moves to C++17... string_view doesn't provide `slice`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63596/new/

https://reviews.llvm.org/D63596