[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Sorry for my delayed review, I want to move this ahead now and commit it.

Can you make sure this works on top-of-trunk (origin/master), hence, rebase it please. Also make sure `make check-all` works without problems.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:93
+    return;
+  }
+
----------------
This should now be checked in the switch below, it is an enum attribute now.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:281
+    // Attrs.emplace_back(Attribute::get(Ctx, "nosync"));
+  // }
+
----------------
Delete this please.


================
Comment at: llvm/test/Transforms/FunctionAttrs/nosync.ll:2
+; RUN: opt -functionattrs -S < %s | FileCheck %s --check-prefix=FNATTR
+; RUN: opt -attributor -S < %s | FileCheck %s --check-prefix=ATTRIBUTOR
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
You need to enable the attributor explicitly, for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766