[PATCH] D63628: AMD K10 (Barcelona) Initial Scheduler model

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 06:53:30 PDT 2019


lebedev.ri added a comment.

In D63628#1555473 <https://reviews.llvm.org/D63628#1555473>, @RKSimon wrote:

> I think I've commented on this before


Oh? I don't remember any such feedback.. Good to know i guess.

> - but why did you pre-commit the test/tools/llvm-mca/X86/Barcelona/* files since adding this model completely overwrites them?

Two-fold:

1. previously clang's `-march=barcelona`would result in what's on the LHS of the diff, and it would now result in the RHS, so the diff does show the *change*; and
2. just easing trying to avoid all the usual pitfalls of git rebase and having to re-come up with proper test file set should things go badly (which IIRC i had to do with `piledriver`)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63628/new/

https://reviews.llvm.org/D63628





More information about the llvm-commits mailing list