[PATCH] D63711: [ARM] MVE VPT Blocks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked 2 inline comments as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:403
+      NextPred = getVPTInstrPredicate(*NextInst, PredReg);
+      LastMI = NextInst;
+      VPTInstCnt++;
----------------
samparker wrote:
> Do we need to keep track of LastMI? Looks like it's only used to get an iterator once out of the loop, but it is derived from MBIter anyway...
cheers, that looks like a good clean-up, will look into that.


================
Comment at: llvm/test/CodeGen/ARM/mve-vpt-block5.mir:66
+
+    ; CHECK:       BUNDLE {{.*}} {
+    ; CHECK-NEXT:    MVE_VPST 8, implicit-def $p0
----------------
samparker wrote:
> So why do we have two bundles here? I'm missing something...
because there is a MOV in between the 2nd and 3rd MVE_VMINNMf32 instructions:

  $q3 = MVE_VORR $q0, $q0, 0, $noreg, undef $q3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63711/new/

https://reviews.llvm.org/D63711