[PATCH] D63628: AMD K10 (Barcelona) Initial Scheduler model

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 06:26:03 PDT 2019


lebedev.ri added a comment.

Wanted to add, it is actually *MORE* correct to stick with `Barcelona` here,
because unlike the `bdver*`/`znver*`/..., where it is known that the sched models
are ideally different, but maybe the same is always used due to the lack of standalone model,
i(?) don't know that for this case, i didn't verify that every single chip in K10 microarch
is identical to the first one, for which this model is.

So i would personally say that, while it is obvious that this sched model is
being used for all the K10 chips, it is for barcelona specifically, and that should be noted.

This isn't new - `bdver2` model is being used for `bdver1` too, even though they are different
and that model is named `bdver2`, not `fam15h`, the generic model is named "<some intel cpu model>"
(sorry don't recall), not <generic cpu model>.

Again, can totally rename, but i'm not sure that will be better/more consistent.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63628/new/

https://reviews.llvm.org/D63628





More information about the llvm-commits mailing list