[PATCH] D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 05:38:49 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/duplicate-symbol-and-section-names.test:4
+## names and that the suffixes produced for each section and
+## symbol reflects the index of duplication.
+
----------------
reflects -> reflect

I'm not sure I understand what "index of duplication" means. Probably sufficient to say that the suffixes are unique (it really doesn't matter how they are unique e.g. with index).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63596/new/

https://reviews.llvm.org/D63596





More information about the llvm-commits mailing list