[PATCH] D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names.

Mon Jun 24 05:04:31 PDT 2019

jhenderson added inline comments.

================
Comment at: test/Object/X86/obj2yaml-dup-section-name.s:1
 # RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-pc-linux
 # RUN: obj2yaml %t.o | FileCheck %s
----------------
grimar wrote:
> jhenderson wrote:
> > I think you still need test cases in both section and symbol cases that show the unique ID is unique for subsequent sections of the same name (i.e. you need a .text.foo, a .text.foo [1], and a .text.foo [2] at least).
> I did what you describe in `CASE1` of `duplicate-symbol-names.test` I think?
> I'll add a one more symbol and one more section there.
> 
> This one can  probably be removed, but I am not sure, since it belongs to `test/Object` and in theory
> tests how we dump the object produced with `llvm-mc`. So I leaved it along.
Okay, I see what caused some of my confusion. `duplicate-symbol-names.test` tests both symbol and section names. It probably needs renaming to something that doesn't suggest it's just about symbol names...!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63596/new/

https://reviews.llvm.org/D63596