[PATCH] D63683: [X86] Cleanups and safety checks around the isFNEG

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 04:21:43 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - as future work I've been wondering whether we should integrate this more with the isNegatibleForFree/GetNegatedExpression helpers in DAGCombine? A quick glance shows that several targets (X86, AMDGPU, ARM, AARCH64, SystemZ) all have very similar logic for generic and target-specific ops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63683/new/

https://reviews.llvm.org/D63683





More information about the llvm-commits mailing list