[PATCH] D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:35
+  // we add a special suffix to make them unique.
   unsigned Suffix = 0;
+
----------------
MaskRay wrote:
> `Suffix` is shared: we may get `.a` `.a [1]` `.b` `.b [2]` `.b [3]`
> 
> Can `DenseSet<StringRef> UsedSectionNames;` be changed to `DenseMap<StringRef, int>` to have a per-section suffix number?
Ok, done. I updated `CASE1` in `obj2yaml\duplicate-symbol-names.test` to test the new logic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63596/new/

https://reviews.llvm.org/D63596