[PATCH] D63628: AMD K10 (Barcelona) Initial Scheduler model

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 03:55:39 PDT 2019


lebedev.ri added a comment.

In D63628#1555278 <https://reviews.llvm.org/D63628#1555278>, @RKSimon wrote:

> Rather pedantic, but shouldn't the model be called K10 or Fam10 instead of Barcelona, which was just one of the chips in the series?


I'm not sure, actually.

This seemed more consistent, because e.g. there are `-mcpu=bdver[1-4]`,
with `bd` being `bulldozer` which was the first chip in the `15h` series.
Those aren't `-mcpu=k15ver[1-4]`, and not `-mcpu={bulldozer,piledriver,steamroller,excavator}`,
and following the consistency logic that is already inconsistent, and latter would be
even more confusing since `bulldozer` would then refer both to the `15h` series
and just a single model in the series, with all other models being different.

This isn't the case here, there is no `-mcpu=k10ver2`;
`-mcpu=fam10h` and `-mcpu=barcelona` are synonyms in `X86.td`
(i don't know if latter chips actually *should* be separate)

So i'm not sure, i can totally rename, but **TO ME** the current scheme follows preexisting pattern.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63628/new/

https://reviews.llvm.org/D63628





More information about the llvm-commits mailing list