[PATCH] D63109: lld-link: Reject more than one resource .obj file

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Sorry for not replying, I'm on vacation.

I've learned that link.exe's /wholearchive is buggy and will do what you'd expect in a future release. So it's going to match lld's current behavior.

A rsrc section contains a tree structure of all resources. Since those don't get merged, if you hit this diag you _will_ get incorrect output. I don't care too much about mingw, but it might make more sense to fix the project running into this, and if that takes a long time, maybe add a /force: thingy for this to downgrade the error to a warning only if users explicitly ask for it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109