[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

Sven van Haastregt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 03:10:19 PDT 2019


svenvh marked 3 inline comments as done.
svenvh added inline comments.


================
Comment at: cfe/trunk/lib/Headers/opencl-c.h:13638-13640
-#ifndef ATOMIC_VAR_INIT
-#define ATOMIC_VAR_INIT(x) (x)
-#endif //ATOMIC_VAR_INIT
----------------
yaxunl wrote:
> kzhuravl wrote:
> > Any reason this piece of code got completely removed?
> Removing ATOMIC_VAR_INIT caused regression in our compiler.
> 
> Could you please put it back?
> 
> Thanks.
Apologies, that was not intended; thanks for reporting!  Restored the macro in r364174 together with a test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63256/new/

https://reviews.llvm.org/D63256





More information about the llvm-commits mailing list