[PATCH] D46628: [ELF] Add --strip-debug-non-line option

Sun Jun 23 21:13:11 PDT 2019

MaskRay added inline comments.

================
Comment at: lld/test/ELF/strip-debug-non-line.s:208
+
+	.ident	"clang version 9.0.0 (https://github.com/llvm/llvm-project 01a99c0aa5ae5be47ea62bd6c87ca6bb63f5a454)"
+	.section	".note.GNU-stack","", at progbits
----------------
luciang wrote:
> MaskRay wrote:
> > .ident, .note.GNU-stack are unnecessary
> I got this from clang output.
> 
> I thought I saw similar in other tests. 
> 
> I didn't want to edit strings to avoid messing offsets but these are fair game to remove. Will do.
If it is not lots of trouble, it'd be nice to minimize the tests. That will emphasize the important parts and make tests easier to understand. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46628/new/

https://reviews.llvm.org/D46628