[PATCH] D63109: lld-link: Reject more than one resource .obj file

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Actually, I'm leaning towards making this only a warning in MinGW cases. If multiple resource objects are passed and the `.rsrc$01` sections are concatenated, is the effect that only the first one actually is read and used, or what does happen?

It turned out that ignoring resource objs in wholearchive cases won't work - in some (all?) projects built for mingw with cmake, with the makefile generator instead of ninja, the object files are packed into an intermediate static library, which is then passed to the linker with `--whole-archive`. So in such cases we actually need to keep the resource object files in such cases, and the VLC issue needs to be dealt with differently.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109