[PATCH] D63618: Exploit a zero LoopExit count to eliminate loop exits

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 23 09:51:42 PDT 2019


reames added a comment.

In D63618#1554009 <https://reviews.llvm.org/D63618#1554009>, @sanjoy wrote:

> Agreed.  I'm mainly curious about the specific test changes in this patch, not with the general idea.


I dug into this a bit, and it turns out the Nikita is partly right.  What's going on is that when we visit a cast (for the widening analysis), we always skip it's users (for the simplifying transforms).  This doesn't seem to really make any sense, and removing it doesn't appear to break any test.  Anyone have any idea why this might be the case?  I'm really tempted to just remove the continue.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63618/new/

https://reviews.llvm.org/D63618





More information about the llvm-commits mailing list