[PATCH] D63619: [AMDGPU] hazard recognizer for fp atomic to s_denorm_mode
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 21 09:01:37 PDT 2019
rampitec marked an inline comment as done.
rampitec added a comment.
In D63619#1553498 <https://reviews.llvm.org/D63619#1553498>, @arsenm wrote:
> LGTM assuming the DS atomics really aren't impacted
According to the ticket that is only vmem.
================
Comment at: lib/Target/AMDGPU/BUFInstructions.td:696
+ bit isFP = getIsFP<vdataType>.ret> {
+ let FPAtomic = isFP in
def _OFFSET : MUBUF_AtomicNoRet_Pseudo <opName, BUFAddrKind.Offset, vdataClass>,
----------------
arsenm wrote:
> I didn't know you could omit the braces here
You do not need braces to cover a single def.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63619/new/
https://reviews.llvm.org/D63619
More information about the llvm-commits
mailing list