[PATCH] D63657: [benchmark] Change GetGitVersion to only check "dirty" when a tag is found

Sat Jun 22 11:47:49 PDT 2019

andrewng added a comment.

In D63657#1553961 <https://reviews.llvm.org/D63657#1553961>, @lebedev.ri wrote:

> 1. Can you just use something along the lines of `git describe --always --dirty` to avoid the `update-index`/`diff-index`?

Yes, you're right, I can just add '--dirty' to the 'describe' and remove the 'dirty' check altogether. This would be equivalent and simpler.

> 2. Can you please either submit this upstream yourself, or explicitly state that it is okay to steal it from you and upstream (to avoid getting out of sync)

I didn't realise that this is kept in sync with upstream. I'm happy for any change to be submitted to the upstream benchmark project.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63657/new/

https://reviews.llvm.org/D63657