[PATCH] D63672: Added Delta IR Reduction Tool
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 22 01:13:57 PDT 2019
lebedev.ri added a comment.
Some observations along the way: the new files aren't following llvm coding style - should start with the same license blob as every other file in the project, should have newline at the end, should make better use of ADT where possible
================
Comment at: llvm/test/BP2/remove-funcs-test.sh:1
+#!/bin/bash
+
----------------
1. You can't assume there is bash, therefore you can't use it for tests
2. there is `not` tool already
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63672/new/
https://reviews.llvm.org/D63672
More information about the llvm-commits
mailing list