[PATCH] D63631: [llvm-objdump] Move --start-address >= --stop-address check out of the -d code.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 4 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2065
+  if (StartAddress >= StopAddress)
+    error("start address should be less than stop address");
+
----------------
jhenderson wrote:
> grimar wrote:
> > Does it make sence to include the address values here? And/or the option name?
> > It is not really clear from the error message text what is wrong it seems.
> I agree that it might be nice to improve the error message. I'm okay with that being a separate change though.
I'll leave it in another patch. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63631/new/

https://reviews.llvm.org/D63631