[PATCH] D63657: [benchmark] Change GetGitVersion to only check "dirty" when a tag is found

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 21 10:37:36 PDT 2019


lebedev.ri added a comment.

1. Can you just use something along the lines of `git describe --always --dirty` to avoid the `update-index`/`diff-index`?
2. Can you please either submit this upstream yourself, or explicitly state that it is okay to steal it from you and upstream (to avoid getting out of sync)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63657/new/

https://reviews.llvm.org/D63657





More information about the llvm-commits mailing list