[PATCH] D62625: LFTR for multiple exit loops

Fri Jun 21 10:26:57 PDT 2019

reames added a comment.

In D62625#1553095 <https://reviews.llvm.org/D62625#1553095>, @mstorsjo wrote:

> Compile time regression. (I build the project it's part of with a 120 second timeout per translation unit, enforced with `ulimit -t 120`, that's why I noticed.)

If you could provide an IR reproducer, and ideally a hint where to look, I can see what I find.  Please file a bug with reproduction instructions and an IR attachment.

In D62625#1553525 <https://reviews.llvm.org/D62625#1553525>, @SjoerdMeijer wrote:

> I think I am mainly looking at micro-architecture sensitivities and some unfortunate knock on effects of this patch. 
>  I don't think I can blame anything of that on this patch. If I change my mind about that, I will let you know. :-) But then I'd of course have to come up with a reproducer (or a fix).
>  Thanks for your help, sorry for the noise!

Np.  I'm happy to help debate fixes for issues you might find.  Feel free to add me as a reviewer (if appropriate), or start an email conversation with preliminary findings if it's helpful.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62625/new/

https://reviews.llvm.org/D62625