[PATCH] D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>

Fri Jun 21 10:17:53 PDT 2019

erichkeane marked an inline comment as done.
erichkeane added a comment.

In D63507#1552849 <https://reviews.llvm.org/D63507#1552849>, @sdesmalen wrote:

> In D63507#1551968 <https://reviews.llvm.org/D63507#1551968>, @erichkeane wrote:
>
> > Can someone take a look at this?
> >  @sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.
>
>
> Thanks, I definitely want to take a look but I’m currently traveling without access to my laptop, so I won’t be able to properly review it until Wednesday.

Great, thanks!

================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:375
   default: break;
+  case MVT::iPTR:
+    UpdateArgCodes(R->getValueAsDef("ElTy"), ArgCodes, NumInserted, Mapping);
----------------
greened wrote:
> Since I don't know this code I can't say whether it's correct, but it seems odd to me that this `iPTR` case is needed to handle ptr-to-any when `iPTRAny` is a case right below.  Does `iPTRAny` not mean "ptr-to-any?"  At the very least a comment would be helpful explaining what is going on here and why we need a separate `iPTR` case to handle ptr-to-any.
> 
iPTRAny is actually "Any Pointer", not "Pointer to Any".  I'm not terribly sure why it makes a difference, but it does.  

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63507/new/

https://reviews.llvm.org/D63507