[PATCH] D63635: [COFF, ARM64] Fix encoding of debugtrap for Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I think fastisel will simply fall back to SDAG, which is fine, but `llc -global-isel` on this test case aborts, so I think you need to handle this next to `Intrinsic::trap` in AArch64InstructionSelector::selectIntrinsicWithSideEffects as well. I could be wrong, though, I haven't worked with globalisel. I believe it's the default strategy for O0 AArch64 codegen these days, so it would be good to be able to select this intrinsic. Otherwise, looks good, thanks for handling this in LLVM.



================
Comment at: test/CodeGen/AArch64/trap.ll:1
+; RUN: llc < %s -mtriple=aarch64-windows | FileCheck %s
+
----------------
Can you add RUN lines to test this with fast and global isel? Just re-run with `-fast-isel` and `-global-isel` using the same CHECKs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63635/new/

https://reviews.llvm.org/D63635