[PATCH] D63639: [AMDGPU] Prevent backend override of WGP when using PAL

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:970-974
+    // Leave WgpMode as default (0) for PAL - PAL will set this bit and should
+    // not be overridden here
+    ProgInfo.WgpMode = (STM.isCuModeEnabled() ||
+                        TM.getTargetTriple().getOS() == Triple::AMDPAL)
+                           ? 0 : 1;
----------------
arsenm wrote:
> This seems like a workaround. Why isn't PAL setting what it wants initially and overriding it later?
I'm also thinking this should be an attribute rather than a sub target feature


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63639/new/

https://reviews.llvm.org/D63639