[PATCH] D63647: [llvm-readobj/llvm-readelf] - Eliminate the elf-groups.x86_64 precompiled binary from the inputs.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-groups.test:2
+## Check that llvm-readelf and llvm-readobj can dump
+## the SHT_GROUP sections properly.
 
----------------
Remove "the".


================
Comment at: test/tools/llvm-readobj/elf-groups.test:47
+  Data:    ELFDATA2LSB
+  OSABI:   ELFOSABI_GNU
+  Type:    ET_REL
----------------
I'm not sure the OSABI is relevant?


================
Comment at: test/tools/llvm-readobj/print-section.test:1
-RUN: llvm-readobj -p .text %p/Inputs/elf-groups.x86_64 \
-RUN:     | FileCheck %s
+## Check that llvm-readobj and llvm-readelf can dump the content
+## of the section as a string.
----------------
I think this test can just be deleted entirely actually. We have string-dump.test and string-dump-multi.test now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63647/new/

https://reviews.llvm.org/D63647