[PATCH] D62680: [ARM] Add MVE vector load/store instructions.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:3063
 
+  void addTMemImm7Shift0OffsetOperands(MCInst &Inst, unsigned N) const {
+    assert(N == 2 && "Invalid number of operands!");
----------------
simon_tatham wrote:
> samparker wrote:
> > Do we really need all these functions that do exactly the same thing?!
> I think all the //names// have to exist, because the Tablegen-generated code will want to call them all by concatenating the innermost operand name (`Imm7Shift1` or similar) into the middle of a standard function-name template. But I can turn them all into trivial wrappers on a single function body.
You can override the function name used by setting the RenderMethod field of the AsmOperandClass, so these could all use the same function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62680/new/

https://reviews.llvm.org/D62680