[PATCH] D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2.

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

> This is weird though because it suggests that the `find_darwin_sdk_dir(DARWIN_iossim_SYSROOT iphonesimulator)` call isn't finding the iOS simulator SDK in your toolchain. Is your toolchain a modified Apple toolchain? For the normal (included with Xcode) Apple toolchain our CMake code doesn't have a problem finding the simulator SDK.

Hmm, yes that seems to be it. Our buildbots use an Xcode that's copied into the build environment, and it seems it doesn't include the iphonesimulator sdk?

  $ export DEVELOPER_DIR=/work/chromium/src/build/mac_files/Xcode.app
  $ xcodebuild -version -sdk iphonesimulator Path
  xcodebuild: error: SDK "iphonesimulator" cannot be located.
  hwennborg-macpro:~ hwennborg$ xcodebuild -version -sdk                     
  iPhoneOS11.3.sdk - iOS 11.3 (iphoneos11.3)
  SDKVersion: 11.3
  Path: /work/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.3.sdk
  PlatformVersion: 11.3
  PlatformPath: /work/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform
  BuildID: C689C3CA-2814-11E8-B440-EB6E943B87E0
  ProductBuildVersion: 15E217
  ProductCopyright: 1983-2018 Apple Inc.
  ProductName: iPhone OS
  ProductVersion: 11.3
  
  MacOSX10.13.sdk - macOS 10.13 (macosx10.13)
  SDKVersion: 10.13
  Path: /work/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk
  PlatformVersion: 1.1
  PlatformPath: /work/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform
  ProductBuildVersion: 17E189
  ProductCopyright: 1983-2018 Apple Inc.
  ProductName: Mac OS X
  ProductUserVisibleVersion: 10.13.4
  ProductVersion: 10.13.4
  
  Xcode 9.3.1
  Build version 9E501

But somehow it was still able to produce an i386 version of libclang_rt.asan_iossim_dynamic.dylib before your change.

Maybe Nico (cc'd) who knows more about our Mac build environment has any ideas?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61242/new/

https://reviews.llvm.org/D61242