[PATCH] D62679: [ARM] Add MVE 64-bit GPR <-> vector move instructions.
Oliver Stannard (Linaro) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 21 03:35:46 PDT 2019
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:1964
+ if (Kind != k_VectorIndex) return false;
+ return VectorIndex.Val == start || VectorIndex.Val == end;
+ }
----------------
The names "start" and "end" are misleading if we're checking for those two exact values, rather than a range of values.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62679/new/
https://reviews.llvm.org/D62679
More information about the llvm-commits
mailing list