[PATCH] D63631: [llvm-objdump] Move --start-address >= --stop-address check out of the -d code.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 21 01:27:05 PDT 2019
grimar added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2065
+ if (StartAddress >= StopAddress)
+ error("start address should be less than stop address");
+
----------------
Does it make sence to include the address values here? And/or the option name?
It is not really clear from the error message text what is wrong it seems.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63631/new/
https://reviews.llvm.org/D63631
More information about the llvm-commits
mailing list